You are reading content from Scuttlebutt
@mix %UUW36at9pybBfYLPdP16FumiVFC1o5jlvYINyGdc+kw=.sha256
Re: %7kkZ8kEGz

Hey @Josiah reviewing this, it looks pretty clearly laid out. One of the main changes that you've made to the logic is coupling this to patchcore, which is what I was keen to avoid. The pattern I'm keen on is being able to take just the server - you can use the server to get those needs you wanted fairly straightforwardly - publish is just straight up a method on server, and you can look at the content of sbot.pull.stream to get the same behaviour but I'm pretty sure it's using a standard method on sbot.

My other major suggestion is that I think the html should not live in this module. The intention of this module is to make get and manipulating tag data easy for any devs in any client (that's my goal that I'm projecting). Experiene suggests the html part should be really handled by each client. e.g. I notice here you've got about.obs.name. Patchless doesn't have that at all, so your view that uses this is not general enough to be useful for that client. I'm still exploring how to do views in a way that's useful across clients. My latest work on maybe more modular views is in patchbay-poll, where my views are as 'dumb' as possible and then I dependency inject things like name, which in the patchbay context could be about.obs.name but anyone can put whatever function they want in there.

I've proposed a call time in PM, if we can confirm that I'll invite @matt as well (Matt we need to be more organised and follow through!)

I'll make a couple of notes on github and open a PR.
I highly recommend adding tests, it will add a lot to your sanity. scuttle-poll has some good examples of testing in this space IMO

Join Scuttlebutt now