{ "type": "pull-request", "project": "%s9mSFATE4RGyJx9wgH22lBrvD4CgUQW4yeguSWWjtqc=.sha256", "repo": "%s9mSFATE4RGyJx9wgH22lBrvD4CgUQW4yeguSWWjtqc=.sha256", "text": "**Enable private messages in light client**\n\nI commented out the line saying private messages are disabled, and it works. The private message view just reads the log and attempts to decrypt messages, so it doesn't rely on sbot's indexing. Was it disabled for another reason that I am not noticing?", "mentions": [], "branch": "master", "head_repo": "%s9mSFATE4RGyJx9wgH22lBrvD4CgUQW4yeguSWWjtqc=.sha256", "head_branch": "privmsgs" }
private messages will work in the /private feed, but not in threads, because that requires indexes.
but, I guess we could make the private threads come purely from the cache, and then we'd be good
@dominic and I talked about this behind the scenes, and there are two problems when you use a remote server.
- Threads don't work
- The entire
/private
pull-scroll loads
Other than that it private messages work fairly well in the lite client. I've turned private messages on when I send people lite client invites from my pubs.
There are no issues using the lite client on your local.
Ok, that makes sense, I forgot about threads. I think an intermediate solution then would be to enable /private
just for local lite client (i.e. compare sbot's whoami with the local key id). I'll update the PR.
It would be nice for lite clients to work on pubs, but I think I will defer on that for now. Private messages could come from the cache but that would only work if they were loaded during the current page load. I think the full solution would be to index the log, at least for thread backlinks, and save the results in localStorage.
@ev 2 happens with remote lite client but not local? I wonder why...
- Enable private messages in local lite client
@cel yeah, I think that would actually be quite feasible for liteclients, it wouldn't be too much data, if you can only seek back on encrypted messages, and also only until when you joined. might as well store the messages which you could decrypt, though (say, in indexeddb)
... because otherwise, you'd have to tell the pub which messages you want, which would effectively leak that you where a recipient in them.
@dominic that sounds good. For now, I've updated this branch to enable /private
if the client is using the same key as the sbot, as a stopgap to let private messages work on a local lite client.
ah, so is this intended for local use in the browser?
Yes, with the key copied into the browser, for local use. It is useful if the browser client works but one can't or doesn't want to use Electron.
this is merged now (though %git-ssb didn't seem to register that I merged this PR.
{ "type": "issue-edit", "root": "%RglDlcmvc3jp7M/BdMLA63St7j2/6eEFoKFIYX+ZyzQ=.sha256", "issues": [ { "link": "%RglDlcmvc3jp7M/BdMLA63St7j2/6eEFoKFIYX+ZyzQ=.sha256", "open": false } ] }